TST: split up test_concat.py #37243 - more follows up #37387
Conversation
* created test_categorical.py
* created test_empty.py * changes to test_series.py
|
I will finish it tomorrow, i didn't have much free time today. There is not much left, i have to create test_sort and test_invalid and make some small changes. |
* created test_categorical.py
* created test_empty.py * changes to test_series.py
* created test_invalid.py * created test_sort.py
…/pandas into i37243_more_follows_up
* created test_index.py * small changes to test_empty.py, test_datetimes.py, test_dataframe.py
|
most of the work should be done, all tests are working, it was 291 passed and 1 xfailed before and it's the same now. |
|
I haven't touched test_append_common and test_append, but these files looks ok for me. |
| import pandas._testing as tm | ||
|
|
||
|
|
||
| @pytest.fixture(params=[True, False]) |
There was a problem hiding this comment.
i would move fixtures to a concat/conftest.py (unless they are truly specific to a particular file)
| import pandas._testing as tm | ||
|
|
||
|
|
||
| @pytest.fixture(params=[True, False]) |
There was a problem hiding this comment.
yeah so this is for sure a common fixture
jreback
added
Reshaping
|
Before: After: |
| def test_concat_series_axis1(self, sort=sort): | ||
| def test_concat_series_axis1(self, sort=True): | ||
| ts = tm.makeTimeSeries() | ||
|
|
There was a problem hiding this comment.
I don't know about this, after moving sort to conftest.py, this test was giving me error, so i have changed default to True. Is this good, or do i have to move fixture to this file and revert this change?
There was a problem hiding this comment.
pls revert this, you should not be changing any code (literally just removing the fixture definition itself)
* reverted changes to test_series.py
|
|
||
|
|
||
| def test_concat_timedelta64_block(): | ||
| from pandas import to_timedelta |
| df = DataFrame({"time": rng}) | ||
|
|
||
| result = concat([df, df]) | ||
| assert (result.iloc[:10]["time"] == rng).all() |
There was a problem hiding this comment.
ca n you this use tm.assert_frame_equal instead (and use a fully constructed dataframe)
|
couple of comments, ping on green. |
|
ok, i will check it in a moment. |
* small changes in test_datetimes.py
|
@jreback everything done |
|
Can I ask what does "ping on green" mean? Is it the green "review changes" button in "files changed" section? Or is it just typing comment, so you can see new activity? |
|
thanks @laffite56 |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff