-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST/REF: collect tests by method #37403
Conversation
expected = DataFrame( | ||
{"A": [0, np.nan], "B": Series(list("ae")).astype(CDT(cats, ordered=True))} | ||
).set_index("B") | ||
tm.assert_frame_equal(result, expected, check_index_type=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you split this test up
return request.param | ||
|
||
|
||
@pytest.fixture(params=[True, False]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be a top-level fixture
|
||
@pytest.mark.parametrize("unit", ["h", "m", "s", "ms", "D", "M", "Y"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally make this a top-level fixture (followon fine)
some comments for followon |
No description provided.