BUG: error raise when column contains percentage #37534
Conversation
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
There was a problem hiding this comment.
lgtm but needs to be looked over by someone who's more familiar with the sql module
@erfannariman would you mind merging master again to make sure this up to date
Done |
|
this was deliberately changed in this was deliberately changed in #34212 so not sure why you think this is a regression. |
doc/source/whatsnew/v1.1.5.rst
Outdated
| @@ -29,6 +29,7 @@ Fixed regressions | |||
| - Fixed performance regression in ``df.groupby(..).rolling(..)`` (:issue:`38038`) | |||
| - Fixed regression in :meth:`MultiIndex.intersection` returning duplicates when at least one of the indexes had duplicates (:issue:`36915`) | |||
| - Fixed regression in :meth:`.GroupBy.first` and :meth:`.GroupBy.last` where ``None`` was considered a non-NA value (:issue:`38286`) | |||
| - Fixed regression in :func:`read_sql_table` raising a ``sqlalchemy.exc.OperationalError`` when column names contained a percentage sign (:issue:`37517`) | |||
There was a problem hiding this comment.
move to 1.2 i think we could put this in.
There was a problem hiding this comment.
Moved it to 1.2 and as bug fix, since it's not a regression fix if I understood you correctly.
jreback
added
IO SQL
|
thanks @erfannariman |
|
@meeseeksdev backport 1.2.x |
…38632) Co-authored-by: Erfan Nariman <34067903+erfannariman@users.noreply.github.com>
%#37157black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff