Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGR: groupby.sem with nuisance columns #38816

Merged
merged 4 commits into from Dec 30, 2020
Merged

REGR: groupby.sem with nuisance columns #38816

merged 4 commits into from Dec 30, 2020

Conversation

rhshadrach
Copy link
Member

We were using the same integer locs in the result of std and count when computing the quotient for sem. However, std will drop nuisance columns and count will not.

I could only find two tests involving nuisance columns, and these only test sum/mean. Created #38815 for a followup.

@rhshadrach rhshadrach added Groupby Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply Regression Functionality that used to work in a prior pandas version labels Dec 30, 2020
@rhshadrach rhshadrach added this to the 1.2.1 milestone Dec 30, 2020
@rhshadrach
Copy link
Member Author

Failure is unrelated.

FAILED pandas/tests/tseries/offsets/test_offsets_properties.py::test_shift_across_dst
= 1 failed, 96932 passed, 4400 skipped, 1090 xfailed, 63 xpassed, 82 warnings in 1150.49s (0:19:10) =

jreback
jreback approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback merged commit 4edb52b into pandas-dev:master Dec 30, 2020
@jreback
Copy link
Contributor

jreback commented Dec 30, 2020

thanks @rhshadrach

@jreback
Copy link
Contributor

jreback commented Dec 30, 2020

@meeseeksdev backport 1.2.x

@meeseeksmachine meeseeksmachine mentioned this pull request Dec 30, 2020
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Dec 30, 2020
@rhshadrach @meeseeksmachine
Backport PR pandas-dev#38816: REGR: groupby.sem with nuisance columns
b1e7b90
jreback pushed a commit that referenced this pull request Dec 31, 2020
@meeseeksmachine @rhshadrach
Backport PR #38816: REGR: groupby.sem with nuisance columns (#38838)
fd4632d 
Co-authored-by: Richard Shadrach <45562402+rhshadrach@users.noreply.github.com>
@rhshadrach rhshadrach deleted the sem_regr branch December 31, 2020 13:33
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@rhshadrach @luckyvs1
REGR: groupby.sem with nuisance columns (pandas-dev#38816)
58dc2a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Groupby Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

BUG: sem() with level raised ValueError in pandas 1.2
2 participants
@rhshadrach @jreback