Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: save site+docs builds as artifacts #39390

Merged
merged 1 commit into from Feb 11, 2021
Merged

Conversation

afeld
Copy link
Member

@afeld afeld commented Jan 25, 2021

Makes the downloadable for previewing locally. Not as good as having a URL to preview it, but better than nothing.

@afeld afeld added CI Continuous Integration Docs Web pandas website labels Jan 25, 2021
@afeld afeld added this to the 1.3 milestone Jan 25, 2021
@datapythonista
Copy link
Member

Personally, I think I'd merge both directories and upload just one artifact. Not a big deal, happy to get this merged as is too. But I think it should make things simpler, and being able to navigate from the web to the docs could be useful.

@jorisvandenbossche
Copy link
Member

Thanks @afeld

I was going to say that indeed if it's not too hard, it would be nice to have a single download. But a potential reason to keep them separate is that the docs are a huge download compared to the website. So if you only want to check the website, having a separate download might be nicer.

Now, I am wondering if we can't get the size down (the docs are now 180Mb), but it seems the largest part is simply all the individual API pages, so no easy way around this with the current generated API docs.

@jreback
Copy link
Contributor

jreback commented Feb 11, 2021

@afeld pls update when you can

@afeld
Copy link
Member Author

afeld commented Feb 11, 2021

Updated to include both the site and docs in the same download. Sorry for the delay!

Makes the site downloadable for previewing locally.
@jreback jreback merged commit 1f3786c into pandas-dev:master Feb 11, 2021
@jreback
Copy link
Contributor

jreback commented Feb 11, 2021

thanks @afeld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Docs Web pandas website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants