Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERR: Unify error message for bad excel sheetnames #39482

Merged
merged 3 commits into from
Feb 1, 2021

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach commented Jan 30, 2021

IMO the core issue in #39250 is upstream in openpyxl, providing a better error message is really tangential to it. Since the error message that openpyxl raises is not a regression, it seemed best to me to (a) target this for 1.3 and (b) unify all error messages across engines.

If, on the other hand, we really do want to improve the error message in 1.2.2 because of the switch from xlrd to openpyxl, then I will open a new PR for 1.2.2 that only impacts openpyxl.

Will do a followup to remove the duplicate tests.

cc @simonjayhawkins @jorisvandenbossche

@rhshadrach rhshadrach added Error Reporting Incorrect or improved errors from pandas IO Excel read_excel, to_excel labels Jan 30, 2021
@jreback jreback added this to the 1.3 milestone Jan 30, 2021
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine. no objection to backporting to 1.2.2 (move the note)

@jreback jreback modified the milestones: 1.3, 1.2.2 Jan 30, 2021
@rhshadrach
Copy link
Member Author

Thanks @jreback, note moved to 1.2.2. bugfixes

@jreback jreback merged commit 9c33e5e into pandas-dev:master Feb 1, 2021
@jreback
Copy link
Contributor

jreback commented Feb 1, 2021

thanks @rhshadrach

@jreback
Copy link
Contributor

jreback commented Feb 1, 2021

@meeseeksdev backport 1.2.x

@lumberbot-app
Copy link

lumberbot-app bot commented Feb 1, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 9c33e5e4f4c5dd6941da866234e506dae7d9f1e0
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #39482: ERR: Unify error message for bad excel sheetnames'
  1. Push to a named branch :
git push YOURFORK 1.2.x:auto-backport-of-pr-39482-on-1.2.x
  1. Create a PR against branch 1.2.x, I would have named this PR:

"Backport PR #39482 on branch 1.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@jreback
Copy link
Contributor

jreback commented Feb 1, 2021

@rhshadrach can you follow the instructions and backport this

simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Feb 1, 2021
simonjayhawkins added a commit that referenced this pull request Feb 1, 2021
…#39536)

Co-authored-by: Richard Shadrach <45562402+rhshadrach@users.noreply.github.com>
rhshadrach added a commit to rhshadrach/pandas that referenced this pull request Feb 1, 2021
@rhshadrach rhshadrach deleted the read_xlsx_error_msg branch February 1, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas IO Excel read_excel, to_excel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: read_excel fails with IndexError: list index out of range
3 participants