Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: fix template substitution in pad/bfill docstrings #39978

Merged
merged 4 commits into from
Feb 24, 2021

Conversation

dylanp-git
Copy link
Contributor

@dylanp-git dylanp-git commented Feb 22, 2021

#39640 Added doc tag above ffill() to substitute klass

@jreback jreback added this to the 1.2.3 milestone Feb 22, 2021
@jreback jreback added the Docs label Feb 22, 2021
@jreback
Copy link
Contributor

jreback commented Feb 22, 2021

cc @simonjayhawkins @jorisvandenbossche

lgtm.

@jreback jreback added the Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate label Feb 22, 2021
@jreback jreback changed the title Fix series pad DOC: update series pad Feb 22, 2021
@simonjayhawkins simonjayhawkins linked an issue Feb 23, 2021 that may be closed by this pull request
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also fix bfill/backfill while doing this. basically same issue, needs same change applied to L6516

@dylanp-git
Copy link
Contributor Author

yeah I can do that. I'm not sure what "Igtm" or "L6516" mean/referring to, if I need to know then could someone let me know please.

@MarcoGorelli
Copy link
Member

@dylanp-git lgtm means 'looks good to me'; L6516 is line number 6516

@dylanp-git
Copy link
Contributor Author

@dylanp-git lgtm means 'looks good to me'; L6516 is line number 6516

aha thankyou, I'm slowly learning the lingo!!

@jorisvandenbossche jorisvandenbossche changed the title DOC: update series pad DOC: fix template substitution in pad/bfill docstrings Feb 24, 2021
@jorisvandenbossche jorisvandenbossche merged commit dec7d21 into pandas-dev:master Feb 24, 2021
@jorisvandenbossche
Copy link
Member

Thanks a lot @dylanp-git !

@dylanp-git
Copy link
Contributor Author

Thanks a lot @dylanp-git !

No worries! I was going to look into it again later as only 20/22 checks passed?

On another note, how many "good first issue" issues do you think I should do before trying something a bit more in-depth?

@MarcoGorelli
Copy link
Member

only 20/22 checks passed?

the failures were unrelated (sometimes that happens)

how many "good first issue" issues do you think I should do before trying something a bit more in-depth?

IMO if you've got familiar with the contribution workflow then you could start immediately

jreback pushed a commit that referenced this pull request Feb 24, 2021
…rings (#40017)

Co-authored-by: Dylan Percy <dylanpercy@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Series.pad has template variables that are not replaced
5 participants