REG: DataFrame/Series.transform with list and non-list dict values #40090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Regression
jreback
requested changes
Feb 26, 2021
doc/source/whatsnew/v1.3.0.rst
Outdated
| @@ -327,6 +327,7 @@ Numeric | |||
| - Bug in :func:`select_dtypes` different behavior between Windows and Linux with ``include="int"`` (:issue:`36569`) | |||
| - Bug in :meth:`DataFrame.apply` and :meth:`DataFrame.agg` when passed argument ``func="size"`` would operate on the entire ``DataFrame`` instead of rows or columns (:issue:`39934`) | |||
| - Bug in :meth:`DataFrame.transform` would raise ``SpecificationError`` when passed a dictionary and columns were missing; will now raise a ``KeyError`` instead (:issue:`40004`) | |||
| - Bug in :meth:`DataFrame.transform` and :meth:`Series.transform` would have incorrect column labels when passed a dictionary with a mix of list and non-list values (:issue:`40018`) | |||
|
seems fine. can you merge master. and then can backport (agreed may require some work on that branch). |
|
|
||
| Ensures that necessary columns exist if obj is a DataFrame, and | ||
| that a nested renamer is not passed. | ||
| that a nested renamer is not passed. Also normalizes to all lists |
There was a problem hiding this comment.
maybe not here if too many changes for a backport, but maybe change function name to say normalize_dictlike_arg
There was a problem hiding this comment.
@simonjayhawkins Thanks for the suggestion. That's actually how I started this out, but then changed it to validate recalling util._validators (some of those do only validate, but a bunch also normalize). I'm seeing a mix of normalize or validate used. I'll change to normalize here, but maybe we should make this consistent.
Related: #19171
jreback
approved these changes
Feb 27, 2021
|
thanks @rhshadrach pls track the backport itself as it likely won't merge cleanly |
|
@meeseeksdev backport 1.2.x |
This comment has been minimized.
This comment has been minimized.
rhshadrach
added a commit
to rhshadrach/pandas
that referenced
this pull request
Feb 27, 2021
…st and non-list dict values
simonjayhawkins
pushed a commit
that referenced
this pull request
Feb 28, 2021
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on master,
aggdoes some preprocessing on dict-like arguments thattransformdoes not, leading to incorrect behavior intransform. This PR movesagg's preprocessing intovalidate_dictlike_argwhich is used by bothaggandtransform, fixing the issue.As identified in #40018, this is a regression from 1.1 -> 1.2 (almost certainly from one of my PRs, but I haven't checked which). Backporting this to 1.2 will probably require a bit of a different fix.