Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPS: replace pyperclip with pyclip #39834 #40101

Closed
wants to merge 14 commits into from

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Feb 27, 2021

@jreback
Copy link
Contributor

jreback commented Feb 27, 2021

wouldn't we need to include this as a dependency?

@jreback jreback added the Dependencies Required and optional dependencies label Feb 27, 2021
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the install.rst instructions for this
can you add a note in the whatsnew (put in the deps section, use a ..warning). as this is basically a breaking change.

so we may want to consider leaving the original impl here (though i find that annoying).

thoughts @pandas-dev/pandas-core

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Mar 5, 2021

thoughts @pandas-dev/pandas-core

Here's my 2 cents, and I will leave it to the more experienced members of the core team to weigh in.

The proposal is that we depend on pyclip instead of pyperclip. Prior to today, I had never heard of either project, so my analysis is based on looking at their GitHub repos.

pyperclip is a project that has been around for almost 10 years. There has not been much activity lately in terms of commits , and it has 71 open issues. But the latest PR was merged on 2/20/21. There have been multiple contributors over the 10 years. As an outsider, I would say that it is probably a pretty stable piece of code.

pyclip is a much younger project, started in January of 2021. There is one contributor. So it is most likely not as "battle tested" as pyperclip. I'd be a little concerned about having pandas depend on such a young project.

So unless pyclip is fixing an issue that affects pandas users that is a problem with using pyperclip, I'd vote for not making this change.

But others may feel differently, because pyclip is the more active project.

@rhshadrach
Copy link
Member

rhshadrach commented Mar 5, 2021

I'll only add that it appears pyperclip requires less on our side, which I love. But I agree with @Dr-Irv assessment. I feel wary adding a 2 month old project, even as an optional dependency. I also wonder how used this feature is (SO gives 161 results for pandas clipboard)

@bashtage
Copy link
Contributor

bashtage commented Mar 5, 2021

I think this is a nearly interactive only function, so I'm not sure it will show up much in github. I have used it a few times in the past month in quick experiments.

@bashtage
Copy link
Contributor

bashtage commented Mar 5, 2021

@Dr-Irv you have an unfortunate type in the fourth paragraph. (fixed)

@jreback
Copy link
Contributor

jreback commented Mar 30, 2021

thanks @fangchenli let's reconsider this after the project is a bit more mature.

@jreback jreback closed this Mar 30, 2021
@fangchenli fangchenli deleted the pyclip-clipboard branch November 18, 2022 02:21
@fangchenli fangchenli restored the pyclip-clipboard branch December 5, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPS: change clipboard backend to pyclip
5 participants