DEPR: Series/DataFrame.transform partial failure except TypeError #40288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Deprecate
…ansform_partial_failure
…ansform_partial_failure � Conflicts: � doc/source/whatsnew/v1.3.0.rst
…ansform_partial_failure
…ansform_partial_failure
|
thanks @rhshadrach |
vladu
pushed a commit
to vladu/pandas
that referenced
this pull request
Apr 5, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial revert of #40238. I did not realize how
TypeErrorwas handled differently than other errors in other UDF functions (#40211 (comment)). The deprecation is now only for partial failure when something other than TypeError is raised.In order to make this work, transform needed to passthrough TypeErrors when they occur so we can correctly decide how to act with a list- or dict-like.