Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYP: Signature of "rename" incompatible with supertype "NDFrame" #40979

Merged
merged 18 commits into from
Nov 26, 2021
Merged

TYP: Signature of "rename" incompatible with supertype "NDFrame" #40979

merged 18 commits into from
Nov 26, 2021

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Apr 16, 2021 •
edited

@WillAyd this should still be backwards compatible, it just makes the signature compatible with its parent's

@MarcoGorelli MarcoGorelli added the Typing type annotations, mypy/pyright type checking label Apr 16, 2021
@MarcoGorelli MarcoGorelli marked this pull request as draft April 16, 2021 14:53
@MarcoGorelli MarcoGorelli marked this pull request as ready for review April 16, 2021 15:51
@jbrockmendel
Copy link
Member

can we remove rewrite_axis_style_signature from DataFrame.rename?

@MarcoGorelli
Copy link
Member Author

can we remove rewrite_axis_style_signature from DataFrame.rename?

I haven't yet made sense fo what rewrite_axis_style_signature does, but I"ll look into it

jreback
jreback requested changes Apr 28, 2021
View reviewed changes
pandas/core/series.py Show resolved Hide resolved
jbrockmendel
jbrockmendel approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcoGorelli MarcoGorelli requested a review from jreback May 3, 2021 16:15
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2021

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jun 3, 2021
@simonjayhawkins simonjayhawkins added the Needs Review Waiting for review/response from a maintainer. label Jun 8, 2021
@lithomas1 lithomas1 requested review from jreback and removed request for jreback June 8, 2021 20:42
@jreback
Copy link
Contributor

jreback commented Oct 4, 2021

still working?

@MarcoGorelli
Copy link
Member Author

Yup, ready for review

jreback
jreback requested changes Oct 11, 2021
View reviewed changes
pandas/core/series.py Show resolved Hide resolved
@jbrockmendel
Copy link
Member

needs rebase

@jreback jreback added this to the 1.4 milestone Nov 26, 2021
@jreback jreback removed the Needs Review Waiting for review/response from a maintainer. label Nov 26, 2021
@jreback jreback merged commit 4f06971 into pandas-dev:master Nov 26, 2021
@jreback
Copy link
Contributor

jreback commented Nov 26, 2021

thanks @MarcoGorelli i realize now why this is convoluted, will be glad to remove this in 2.0

@MarcoGorelli MarcoGorelli deleted the rename-compatibility branch November 26, 2021 17:44
@MarcoGorelli MarcoGorelli mentioned this pull request Nov 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@jbrockmendel jbrockmendel jbrockmendel approved these changes

@WillAyd WillAyd Awaiting requested review from WillAyd

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

TYP: Signature of "rename" incompatible with supertype "NDFrame"
4 participants
@MarcoGorelli @jbrockmendel @jreback @simonjayhawkins