BUG: rolling mean and sum not numerical stable for all nan window #41106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rking � Conflicts: � doc/source/whatsnew/v1.3.0.rst
mroeschke
reviewed
Apr 23, 2021
| ] | ||
| ) | ||
|
|
||
| expected = DataFrame( |
There was a problem hiding this comment.
Mind parameterizing over expected and the slice?
There was a problem hiding this comment.
Could yes, but you make a pretty long parametrization, because most of exepected differs too
There was a problem hiding this comment.
Parametrized, got a bit better :)
mroeschke
reviewed
Apr 23, 2021
mroeschke
approved these changes
Apr 24, 2021
|
cc @mroeschke on master. Sum should be the only other case we have the problem. As long as all nan should return 0 we can do it this way |
phofl
changed the title
mroeschke
requested changes
Apr 25, 2021
doc/source/whatsnew/v1.3.0.rst
Outdated
| @@ -846,6 +846,7 @@ Groupby/resample/rolling | |||
| - Bug in :meth:`GroupBy.cummin` and :meth:`GroupBy.cummax` incorrectly rounding integer values near the ``int64`` implementations bounds (:issue:`40767`) | |||
| - Bug in :meth:`.GroupBy.rank` with nullable dtypes incorrectly raising ``TypeError`` (:issue:`41010`) | |||
| - Bug in :meth:`.GroupBy.cummin` and :meth:`.GroupBy.cummax` computing wrong result with nullable data types too large to roundtrip when casting to float (:issue:`37493`) | |||
| - Bug in :meth:`DataFrame.rolling` returning mean zero, respectively sum not zero for all ``NaN`` window with ``min_periods=0`` if calculation is not numerical stable (:issue:`41053`) | |||
There was a problem hiding this comment.
Could you add 2 separate lines for the mean bug and sum bug for clarity?
mroeschke
approved these changes
Apr 25, 2021
|
thanks @phofl |
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
May 6, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is not numerical stable, so we are dividing -3e-18 / 0, which returns -inf running into line 177 setting to 0. Checking for nobs > 0 would solve these cases
cc @mroeschke