Deprecate passing args as positional in dropna #41504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
deprecate-nonkeyword-args-dropna
branch
from
31f7cbc
to
2660810
Compare
| @@ -231,3 +231,13 @@ def test_dropna_with_duplicate_columns(self): | |||
|
|
|||
| result = df.dropna(subset=["A", "C"], how="all") | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| def test_dropna_pos_args_deprecation(self): | |||
There was a problem hiding this comment.
could probably share this test using frame_or_series fixture?
| r"argument 'self' will be keyword-only" | ||
| ) | ||
| with tm.assert_produces_warning(FutureWarning, match=msg): | ||
| df.dropna(1) |
There was a problem hiding this comment.
Similar as in other PRs, can you still assert the result?
jorisvandenbossche
changed the title
MarcoGorelli
force-pushed
the
deprecate-nonkeyword-args-dropna
branch
from
8c0a0d7
to
d4ad702
Compare
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inplace#41485