Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated nonkeyword arguments for set_codes function #41650

Merged
merged 6 commits into from May 27, 2021
Merged

Deprecated nonkeyword arguments for set_codes function #41650

merged 6 commits into from May 27, 2021

Conversation

Pydare
Copy link
Contributor

@Pydare Pydare commented May 24, 2021 •
edited by simonjayhawkins

@pep8speaks
Copy link

pep8speaks commented May 24, 2021 •
edited

Hello @Pydare! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-27 13:21:34 UTC

@simonjayhawkins simonjayhawkins added the Deprecate Functionality to remove in pandas label May 25, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone May 25, 2021
@jreback
Copy link
Contributor

jreback commented May 26, 2021

this is failing some precommit tests, pls rebase and fix up.

simonjayhawkins
simonjayhawkins reviewed May 26, 2021
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pydare merge conflicts to resolve and whitespace issues, need to run black or pre-commit

https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit

doc/source/whatsnew/v1.3.0.rst Show resolved Hide resolved
pandas/tests/indexes/multi/test_get_set.py Outdated
],
names=["foo", "bar"]
)
tm.assert_index_equal(result, expected)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint issue

@jreback jreback mentioned this pull request May 26, 2021
Closed
simonjayhawkins
simonjayhawkins approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Pydare lgtm pending green

@jreback jreback merged commit 1fe2a54 into pandas-dev:master May 27, 2021
@jreback
Copy link
Contributor

jreback commented May 27, 2021

thanks @Pydare

TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
@Pydare @TLouf
Deprecated nonkeyword arguments for set_codes function (pandas-dev#41650
94a39df 
)
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@Pydare @JulianWgs
Deprecated nonkeyword arguments for set_codes function (pandas-dev#41650
39b6e04 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli left review comments

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Pydare @pep8speaks @jreback @simonjayhawkins @MarcoGorelli