Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: make numpy.typing available from pandas._typing #41945

Merged
merged 7 commits into from Jun 25, 2021

Conversation

simonjayhawkins
Copy link
Member

xref #41807 (comment)

this does not update the __array__ to to_numpy methods of EA, see #41185 (comment) but does need a couple of ignores till that is done.

(we are removing 3 anyway, so a net reduction in ignores 馃槃, and reducing false positives for users)

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Jun 11, 2021
@jreback
Copy link
Contributor

jreback commented Jun 25, 2021

does this require 1.21? (though passing for all so guess is no)

@jreback jreback added this to the 1.4 milestone Jun 25, 2021
@simonjayhawkins
Copy link
Member Author

for runtime, npt: Any = None means that the numpy version is not relevant. For type checking, import numpy.typing as npt so needs at least 1.20, but would not be checking without 1.21 anyway otherwise will get other errors.

@jreback jreback merged commit 50a59ba into pandas-dev:master Jun 25, 2021
@jreback
Copy link
Contributor

jreback commented Jun 25, 2021

thanks @simonjayhawkins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants