Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't combine DatetimeIndex MultiIndex with numeric MultiIndex #42143

Merged
merged 12 commits into from Dec 19, 2021
Merged

Can't combine DatetimeIndex MultiIndex with numeric MultiIndex #42143

merged 12 commits into from Dec 19, 2021

Conversation

Alex-JG3
Copy link
Contributor

@Alex-JG3 Alex-JG3 commented Jun 20, 2021 •
edited by jreback

@jreback jreback added this to the 1.4 milestone Jun 21, 2021
@jreback jreback added Index Related to the Index class or subclasses MultiIndex Timeseries labels Jun 21, 2021
@jreback jreback changed the title This is a test for issue 23478. Can't combine DatetimeIndex MultiIndex with numeric MultiIndex Jun 21, 2021
jreback
jreback requested changes Jun 21, 2021
View reviewed changes
pandas/tests/indexing/multiindex/test_multiindex.py Outdated
for columns in columns_list
]

for i, j in combinations(range(len(dfs)), 2):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you parameterize instead of doing thsi.

pls check the warning text as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment. I have attempted to parameterize the test as requested. I suspect I am not using assert_produces_warning correctly, could you give any hints how I should correctly check for the TypeErrors?

@Alex-JG3 Alex-JG3 requested a review from jreback July 1, 2021 21:44
@mzeitlin11
Copy link
Member

@AlexGregory96 are there other concat tests in this file? I think

pandas/pandas/tests/reshape/concat/test_index.py

Line 192 in b0082d2

class TestMultiIndexConcat:
would be a more natural location

@mzeitlin11 mzeitlin11 added the Reshaping Concat, Merge/Join, Stack/Unstack, Explode label Jul 1, 2021
jreback
jreback requested changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a file path_to_file.xlsx is included somehow, can you remove. otherwise lgtm.

@Alex-JG3 Alex-JG3 requested a review from jreback July 11, 2021 12:25
@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Aug 11, 2021
@mroeschke mroeschke removed the Stale label Aug 17, 2021
@jreback
Copy link
Contributor

jreback commented Aug 17, 2021

this needs a rebase

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Sep 21, 2021
@jreback
Copy link
Contributor

jreback commented Nov 28, 2021

pls merge master and address comments

mroeschke
mroeschke approved these changes Dec 19, 2021
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI failure unrelated

@jreback jreback merged commit bd5ecc3 into pandas-dev:master Dec 19, 2021
@jreback
Copy link
Contributor

jreback commented Dec 19, 2021

thanks @Alex-Gregory-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@jreback jreback jreback approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Index Related to the Index class or subclasses MultiIndex Reshaping Concat, Merge/Join, Stack/Unstack, Explode Stale Timeseries
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

Can't combine DatetimeIndex MultiIndex with numeric MultiIndex
6 participants
@Alex-JG3 @mzeitlin11 @jreback @jbrockmendel @mroeschke @Alex-Gregory-AITIS