Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYP: clean for PY3.8 (Literal) #42385

Merged
merged 1 commit into from
Jul 6, 2021
Merged

TYP: clean for PY3.8 (Literal) #42385

merged 1 commit into from
Jul 6, 2021

Conversation

simonjayhawkins
Copy link
Member

No description provided.

@simonjayhawkins simonjayhawkins added Clean Typing type annotations, mypy/pyright type checking labels Jul 5, 2021
@jbrockmendel
Copy link
Member

39 failure looks unrelated; ive seen it on at least one other PR today

@simonjayhawkins
Copy link
Member Author

#42381

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Jul 6, 2021

@simonjayhawkins I don't think this will work with python 3.7. Does that mean we are dropping support for 3.7 in the near future?

@simonjayhawkins
Copy link
Member Author

already dropped. #41678

@jreback jreback added this to the 1.4 milestone Jul 6, 2021
@jreback jreback merged commit e102f80 into pandas-dev:master Jul 6, 2021
@jreback
Copy link
Contributor

jreback commented Jul 6, 2021

thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the typing-38 branch July 6, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@simonjayhawkins @jbrockmendel @Dr-Irv @jreback