Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: styler.format options #43256

Merged
merged 10 commits into from Aug 31, 2021
Merged

Conversation

attack68
Copy link
Contributor

@attack68 attack68 commented Aug 27, 2021

update user guide will be a follow-on when all options are merged

Screen Shot 2021-08-28 at 13 26 44

@attack68 attack68 marked this pull request as draft August 27, 2021 17:28
@attack68 attack68 changed the title WIP ENH: styler.format options ENH: styler.format options Aug 28, 2021
@attack68 attack68 marked this pull request as ready for review August 28, 2021 11:06
@simonjayhawkins simonjayhawkins added Enhancement Styler conditional formatting using DataFrame.style labels Aug 29, 2021
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. technically this could break code if some actually uses pd.set_option('precision') for example but that will now raise so prob ok.

@jreback jreback added this to the 1.4 milestone Aug 31, 2021
@jreback jreback merged commit 08ac29a into pandas-dev:master Aug 31, 2021
@jreback
Copy link
Contributor

jreback commented Aug 31, 2021

thanks pls check the options on the issue :->

@attack68 attack68 deleted the styler_format_options branch August 31, 2021 20:55
@attack68
Copy link
Contributor Author

looks good. technically this could break code if some actually uses pd.set_option('precision') for example but that will now raise so prob ok.

the docs do advise against that behaviour for this specific reason, so I think ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Styler conditional formatting using DataFrame.style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants