BUG: rolling.groupby with on and __getitem__ doesn't mutate underlying object #43374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
Sep 3, 2021
mroeschke
commented
- closes BUG: Groupby rolling count gives inconsistent outputs with missing index #43355
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jbrockmendel
reviewed
Sep 3, 2021
doc/source/whatsnew/v1.4.0.rst
Outdated
| @@ -398,6 +398,7 @@ Groupby/resample/rolling | |||
| - Bug in :meth:`pandas.DataFrame.rolling` operation along rows (``axis=1``) incorrectly omits columns containing ``float16`` and ``float32`` (:issue:`41779`) | |||
| - Bug in :meth:`Resampler.aggregate` did not allow the use of Named Aggregation (:issue:`32803`) | |||
| - Bug in :meth:`Series.rolling` when the :class:`Series` ``dtype`` was ``Int64`` (:issue:`43016`) | |||
| - Bug in :meth:`DataFrame.groupby.rolling` when specifying ``on`` and calling ``__getitem__`` would return subsequent incorrect results (:issue:`43355`) | |||
There was a problem hiding this comment.
"return subsequent" -> "subsequently return"?
|
Thanks @mroeschke This does not close the issue? (as indicated in the OP) There are still the issues of the inconsistent indexes between |
Thanks @mroeschke
there was a typo here. the index didn't change from 1.2.5, the result columns did. There was a change in index from 1.1.5. I've commented on the issue. #43405 (comment) |
…ng_on_getitem_mutate
…ng_on_getitem_mutate
|
thanks @mroeschke |
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.