Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #43150 on branch 1.3.x (BUG: GroupBy.quantile fails with pd.NA) #43408

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #43150: BUG: GroupBy.quantile fails with pd.NA

@lumberbot-app lumberbot-app bot added this to the 1.3.3 milestone Sep 4, 2021
@lumberbot-app lumberbot-app bot added Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Sep 4, 2021
@jreback
Copy link
Contributor

jreback commented Sep 5, 2021

@debnathshoham

need to change the any_float_dtype fixtures as that is changed in 1.4 e.g. https://github.com/pandas-dev/pandas/pull/43408/checks?check_run_id=3515311784

and update the PR to this branch

@debnathshoham
Copy link
Member

debnathshoham commented Sep 5, 2021

Will have to change any_int_ea_dtype to any_nullable_int_dtype, and any_float_dtype to any_float_allowed_nullable_dtype.
Again, since not my PR will need help from maintainer.

Little confused why test_groupby_quantile_allNA_column is failing though

@simonjayhawkins
Copy link
Member

@debnathshoham you can fork this PR and create a new one (or I can do it.. LMK)

@debnathshoham
Copy link
Member

hi @simonjayhawkins - not sure how to fork this PR (didn't get anything on google; can try if you can point me to something that explains how to do it).
Or, are you suggesting I fork the 1.3.x branch?

@simonjayhawkins
Copy link
Member

There's an "open with" button in the top right next to the issue title. (if using github through the web)

@lithomas1
Copy link
Member

Closing in favor of #43417

@lithomas1 lithomas1 closed this Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants