TST: More type checking during .(i)loc #44015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimcmaster1
added
Regression
|
oh i c you are just testing this, needs a patch. |
|
Yes. I'm unsure how to patch this just yet. |
|
@DamianBarabonkovQC wanna trade? I'll figure out the patch for this and ask you to take a look at a less esoteric issue? |
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
closing as stale if you want to continue, pls ping to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas/tests/indexing/test_iloc.pyAs explained in issue #43996, the update of v1.3.0 causes a change in dtype casting when assigning a series. The issue contains a minimal working example of this rather inconsistent behaviour. In short, the type of a column changes when the assignment happens on a data frame only containing one column. With multiple columns, assigning the same series retains the original type.
This contribution includes a test case which performs an assignment operation on a single column data frame. Naturally, because of this inconsistency of typing in the current pandas code, this test case fails. Its aim is to serve the bug fix for this inconsistency.