BUG: broadcasting listlike values in Series.__setitem__ GH#44265 #44275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
changed the title
lithomas1
added
Bug
Indexing
|
@jreback following this we can get rid of both putmask_preserve and putmask_without_repeat |
|
can you rebase |
|
rebased + greenish |
jreback
requested changes
Nov 4, 2021
| @@ -309,7 +307,17 @@ def test_broadcast(size, mask, item, box): | |||
| ) | |||
|
|
|||
| s = Series(data) | |||
| s[selection] = box(item) | |||
|
|
|||
| if selection.sum() != 1: | |||
There was a problem hiding this comment.
hmm maybe make this another test
it's really confusing u r boxing first then setting it after
|
updated + greenish |
4 tasks
jreback
approved these changes
Nov 5, 2021
|
lgtm @phofl if you can have a look |
|
thx @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should in turn allow us to avoid some special-casing that we do in internals/putmask_smart.
Sits on top of #44261