Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cython version for asv conf #44359

Merged
merged 2 commits into from Nov 9, 2021
Merged

Update cython version for asv conf #44359

merged 2 commits into from Nov 9, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 8, 2021

@phofl phofl added the Benchmark Performance (ASV) benchmarks label Nov 8, 2021
alimcmaster1
alimcmaster1 approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any of the benchmarks change dramatically with this change?

alimcmaster1
alimcmaster1 reviewed Nov 8, 2021
View reviewed changes
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cython>=0.29.21 seems to be in environment.yml. Think this needs bumped.

@alimcmaster1 alimcmaster1 self-requested a review November 8, 2021 23:17
@jreback
Copy link
Contributor

jreback commented Nov 9, 2021

we bumped the min to support 3.10

@lithomas1 lithomas1 added this to the 1.4 milestone Nov 9, 2021
jbrockmendel
jbrockmendel approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phofl
Copy link
Member Author

phofl commented Nov 9, 2021

Modified enviornment and requirements too

@simonjayhawkins
Copy link
Member

Do any of the benchmarks change dramatically with this change?

I changed this on the 1.3.x tracker (https://simonjayhawkins.github.io/fantastic-dollop/) a couple of weeks back. Haven't noticed any significant changes.

@jbrockmendel
Copy link
Member

FWIW ive changed my local asv.conf.json to use py39

jreback
jreback approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm merge away

@phofl phofl merged commit 7c2d28c into pandas-dev:master Nov 9, 2021
@phofl phofl deleted the 44067 branch November 9, 2021 21:25
@alimcmaster1 alimcmaster1 mentioned this pull request Nov 14, 2021
Open
@jorisvandenbossche jorisvandenbossche mentioned this pull request Nov 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@jbrockmendel jbrockmendel jbrockmendel approved these changes

@alimcmaster1 alimcmaster1 Awaiting requested review from alimcmaster1

Assignees
No one assigned
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

BUG: CI cannot create benchmark environments with Cython < 0.29.24
6 participants
@phofl @jreback @simonjayhawkins @jbrockmendel @alimcmaster1 @lithomas1