CLN: TODOs #44733
Merged
CLN: TODOs #44733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Dec 3, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
| # result = arr[mask] | ||
| # TODO: belongs somewhere else? | ||
| @pytest.mark.xfail(reason="fails to raise") | ||
| def test_indexing_boolean_mask(): |
There was a problem hiding this comment.
I think this can simply be removed. I checked git blame, and this was added as commented out test in the initial PR adding the BooleanArray (#29555), but which didn't yet specify the indexing behaviour. This was only done in a follow-up (#30308, #31591), which added plenty of tests.
(the test is now also outdated)
jreback
approved these changes
Dec 3, 2021
|
timeout unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.