REG/REF: close file handles engine-independently in read_csv #45389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
can we merge this to 1.4? i think its pretty comprehensive |
|
Yes, can go in 1.4.0 Just wasn't sure whether there will be enough time for this. |
|
thanks @twoertwein |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 16, 2022
…pendently in read_csv
|
@meeseeksdev backport 1.4.x |
|
Something went wrong ... Please have a look at my logs. |
jreback
pushed a commit
that referenced
this pull request
Jan 17, 2022
…in read_csv (#45398) Co-authored-by: Torsten Wörtwein <twoertwein@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open file handles in TextFileParser instead of in the read_csv engines. This makes it easier to close file handles in case of an error.
It is probably better to merge #45388 (for 1.4.x) and then this PR for 1.5.