Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: accept strings in FloatingArray._from_sequence #45424

Merged
merged 4 commits into from
Jan 23, 2022

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jan 17, 2022

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Makes FloatingArray behavior match IntegerArray. After this we can refactor to share most of coerce_to_array.

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Needs whatsnew?

@mroeschke mroeschke added the ExtensionArray Extending pandas with custom dtypes or arrays. label Jan 18, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jan 18, 2022
@jreback
Copy link
Contributor

jreback commented Jan 22, 2022

yep can you add a note & rebase

@jbrockmendel
Copy link
Member Author

whatsnew added + green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants