Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/ER: Stricter testing of 'monotocity' when reindexing with ffill (GH4483) #4642

Closed
wants to merge 2 commits into from

Conversation

prossahl
Copy link
Contributor

This fixes up an earlier pull request and closes #4484.

Note these methods generally assume that the indexes are **sorted**. They may
be modified in the future to be a bit more flexible but as time series data is
ordered most of the time anyway, this has not been a major priority.
Note that this method does not check the order of the index.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add: that this will raise a ValueError will be raised if the index is not monotonic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now fixed.

@jreback
Copy link
Contributor

jreback commented Aug 22, 2013

minor doc point, otherwise looks ok

@wesm
Copy link
Member

wesm commented Aug 22, 2013

👍

jtratner added a commit to jtratner/pandas that referenced this pull request Sep 15, 2013
BUG/ER: Stricter testing of 'monotocity' when reindexing with ffill (GH4483)
@jtratner
Copy link
Contributor

Merged into master with 95ff747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG/ER: misleading results when filling with a reversed index
4 participants