DEPR: Timedelta.delta #46476
Merged
DEPR: Timedelta.delta #46476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Mar 22, 2022
| @@ -1014,6 +1014,12 @@ cdef class _Timedelta(timedelta): | |||
| >>> td.delta | |||
| 42 | |||
| """ | |||
| # Deprecated GH#46476 | |||
| warnings.warn( | |||
| "Timedelta.delta is deprecated and will be removed in a future version.", | |||
There was a problem hiding this comment.
Probably good to mention the alternative in the message?
There was a problem hiding this comment.
i'm not sure there is a good alternative. since the meaning of .value may change as we get non-nano working
There was a problem hiding this comment.
In [96]: td / pd.Timedelta('1ns')
Out[96]: 123456546.0
In [97]: td / pd.Timedelta('1s')
Out[97]: 0.123456546
you can say the alt is to convert a float like this which puts it in the specified units.
There was a problem hiding this comment.
well neither of those is the same behavior they're getting now.
Telling the user how to "keep the same behavior" really depends on what they are trying to do:
- using .value directly is good if they just want to get at the guts of the object
- or .view("i8") if for some reason they want the same thing but slower
- if they really care about getting a number of nanoseconds then they need obj.to_timedelta64("ns").view("i8") (which risks overflowing in a non-nano world)
I think we deprecate like this and wait to see if anyone complains.
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.It's redundant and promises to become confusing once we have non-nano td64.