Fix a few test failures on big-endian systems #46681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Apr 7, 2022
jreback
added
Testing
These are all due to tests expecting little-endian dtypes, where in fact the endianness of the dtype is that of the host.
Setting an ENDIAN constant here to represent the character for
host-endianness to use for numpy dtypes ("<" or ">") saves an import and
a little duplicated code across a number of test modules.
musicinmybrain
force-pushed
the
big-endian
branch
from
44ba9e6
to
6d8725a
Compare
|
The force push was to remove a stray |
jreback
approved these changes
Apr 7, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all due to tests expecting little-endian dtypes, where in fact the endianness of the dtype is that of the host.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.