New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: initial support for non-nano Timestamp #46839

Merged

jreback merged 4 commits into pandas-dev:main from jbrockmendel:enh-nano-ts-2

Apr 27, 2022

Member

jbrockmendel commented Apr 22, 2022

closes #xxxx (Replace xxxx with the Github issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

jbrockmendel added 2 commits

April 22, 2022 10:46


          ENH: initial support for non-nano Timestamp

4c971b5


          update setup.py

ca4d689

jbrockmendel mentioned this pull request

CI/TST: xfail git test failure on 32 bit job #46842

Merged

2 tasks

mroeschke reviewed

View reviewed changes

Member

mroeschke left a comment

So just to confirm, this PR just allows preserving the resolution from np.datetime64 objects? Do you have plans to support passing in resolution from the Timestamp constructor too?

mroeschke added Enhancement Timeseries Non-Nano labels

mroeschke added this to the 1.5 milestone

Member Author

jbrockmendel commented Apr 23, 2022

So just to confirm, this PR just allows preserving the resolution from np.datetime64 objects?

Correct. This way I can incrementally implement tests for tznaive cases, then expand to tzaware cases, etc.

Do you have plans to support passing in resolution from the Timestamp constructor too?

Yes, though the exact API is still up in the air (xref #46587). On last week's dev call we were leaning towards a new keyword, though im still reticent, so punting on this for the time being.

mroeschke approved these changes

View reviewed changes

Member Author

jbrockmendel commented Apr 25, 2022

@jreback gentle ping; nothing time-sensitive, but many more steps to go (ditto #46847, #46828, #46811, #46803)

jbrockmendel added 2 commits

April 25, 2022 14:35


          Merge branch 'main' into enh-nano-ts-2

58a2bba


          Merge branch 'main' into enh-nano-ts-2

5c79056

jreback approved these changes

View reviewed changes

pandas/_libs/tslibs/timestamps.pyx

+                  # Constructors
+                  @classmethod
+                  def _from_dt64(cls, dt64: np.datetime64):

Contributor

jreback Apr 27, 2022

ideally can return type (followon)

jreback merged commit d0e3820 into pandas-dev:main

jbrockmendel deleted the enh-nano-ts-2 branch

April 27, 2022 15:02

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request


          ENH: initial support for non-nano Timestamp (pandas-dev#46839)

5e0e1d0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment