ENH: non-nano Timestamp.timestamp, to_period #46990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
May 11, 2022
| @@ -348,6 +348,19 @@ cdef int64_t periods_per_day(NPY_DATETIMEUNIT reso=NPY_DATETIMEUNIT.NPY_FR_ns) e | |||
| return day_units | |||
|
|
|||
|
|
|||
| cdef int64_t periods_per_second(NPY_DATETIMEUNIT reso) except? -1: | |||
There was a problem hiding this comment.
This can't be defined with periods_per_day because of timezones?
mroeschke
reviewed
May 11, 2022
| @@ -348,6 +348,19 @@ cdef int64_t periods_per_day(NPY_DATETIMEUNIT reso=NPY_DATETIMEUNIT.NPY_FR_ns) e | |||
| return day_units | |||
|
|
|||
|
|
|||
| cdef int64_t periods_per_second(NPY_DATETIMEUNIT reso) except? -1: | |||
There was a problem hiding this comment.
This can't be defined with periods_per_day because of timezones?
There was a problem hiding this comment.
we could share for some cases, but for not for e.g. NPY_FR_h
mroeschke
reviewed
May 11, 2022
|
|
||
| if self._reso != NPY_FR_ns: | ||
| raise NotImplementedError(self._reso) | ||
|
|
||
| normalized = normalize_i8_stamp(local_val) | ||
| normalized = normalize_i8_stamp(local_val, ppd) |
There was a problem hiding this comment.
Do we have non-nano tests for normalize()?
There was a problem hiding this comment.
not yet, still raises a few lines up, per commit message this is preliminary
mroeschke
reviewed
May 11, 2022
|
|
||
| if self._reso != NPY_FR_ns: | ||
| raise NotImplementedError(self._reso) | ||
|
|
||
| normalized = normalize_i8_stamp(local_val) | ||
| normalized = normalize_i8_stamp(local_val, ppd) |
There was a problem hiding this comment.
Do we have non-nano tests for normalize()?
mroeschke
added
Enhancement
Non-Nano
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* ENH: Timestamp.timestamp non-nano * ENH: Timestamp.to_period non-nano * normalize prelims
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.