Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: groupby.transform not aligning with input index #47244

Merged
merged 9 commits into from Jun 11, 2022
Merged

DEPR: groupby.transform not aligning with input index #47244

merged 9 commits into from Jun 11, 2022

Conversation

rhshadrach
Copy link
Member

cc @jbrockmendel

@rhshadrach rhshadrach added Groupby Deprecate Functionality to remove in pandas Apply Apply, Aggregate, Transform labels Jun 5, 2022
@rhshadrach rhshadrach added this to the 1.5 milestone Jun 5, 2022
jreback
jreback requested changes Jun 5, 2022
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

pandas/core/groupby/groupby.py Show resolved Hide resolved
pandas/core/groupby/generic.py Show resolved Hide resolved
doc/source/user_guide/groupby.rst Show resolved Hide resolved
@rhshadrach
Copy link
Member Author

Thanks @jreback - changes made

@rhshadrach
Merge branch 'main' of https://github.com/pandas-dev/pandas into tran…
bef21cf 
…sform_alignment

� Conflicts:
�	doc/source/whatsnew/v1.5.0.rst
@rhshadrach rhshadrach mentioned this pull request Jun 10, 2022
Closed
3 tasks
@jreback
Copy link
Contributor

jreback commented Jun 10, 2022

lgtm merge on green

@jreback jreback mentioned this pull request Jun 11, 2022
Closed
@jreback jreback merged commit c07a910 into pandas-dev:main Jun 11, 2022
@jreback
Copy link
Contributor

jreback commented Jun 11, 2022

thanks @rhshadrach

@rhshadrach rhshadrach deleted the transform_alignment branch June 12, 2022 12:12
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@rhshadrach @yehoshuadimarsky
DEPR: groupby.transform not aligning with input index (pandas-dev#47244)
359e941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform Deprecate Functionality to remove in pandas Groupby
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

BUG: groupby transform doesn't respect Series index anymore
2 participants
@rhshadrach @jreback