BUG: Fix date_format and datetime_format arguments to ExcelWriter being ignored #47315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swap rows and columns so that columns are homogenous and dates aren't converted to datetimes (i.e. datetime64[ns]) on initialisation of df. Clarify scope of test.
Avoid messy branching within test due to handling different engines in parametrization on TestExcelWriter class. Different engines have different APIs for accessing formatting info so probably better as tests in per-engine test files, even though this entails some duplication across files.
TimoMorris
changed the title
phofl
reviewed
Jun 14, 2022
mroeschke
reviewed
Jul 21, 2022
|
|
||
| def test_write_date_datetime_format(ext): | ||
| # see gh-44284 | ||
| xlrd = pytest.importorskip("xlrd") |
There was a problem hiding this comment.
This shouldn't be needed. It's already called near the top of the file
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Notes:
TestExcelWriterclass, which is parametrized over the different writers, gave some quite awkward code branching between the different APIs for the different engines. So I decided to move the tests to the test files for each individual engine, though this leaves some duplication between them.Potential outstanding issues:
TextExcelWriterto the individual test files meant losing theopenpyxl-.xlsmparameter, since there didn't seem to be a file where this extension was being tested.ODSWriterdoes not seem to respect them, and this may be a limitation of the ODF specification. This felt like it was out-of-scope for this bug. Consequently, there was not a test added for the ODF engine.