Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Updating some capitalization in doc/source/user_guide #32550 #47732

Merged
merged 3 commits into from
Jul 22, 2022

Conversation

SomtochiUmeh
Copy link
Contributor

@SomtochiUmeh SomtochiUmeh marked this pull request as draft July 15, 2022 17:05
@SomtochiUmeh SomtochiUmeh marked this pull request as ready for review July 15, 2022 17:06
@jreback jreback added the Docs label Jul 15, 2022
@jreback jreback added this to the 1.5 milestone Jul 15, 2022
@@ -67,7 +67,7 @@ Further, operations among the scalars yield another scalar ``Timedelta``.
"00:00:00.000123"
)

to_timedelta
To_timedelta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would leave this one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@@ -266,7 +266,7 @@ have no replacement.

.. _sparse.scipysparse:

Interaction with scipy.sparse
Interaction with SciPy.sparse
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave this one (could make it italitc or code style though)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Added a few questions

@@ -874,7 +874,7 @@ is already ``False``):
True & pd.NA


``NA`` in a boolean context
``NA`` in a Boolean context
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"boolean" doesn't refer to a Boolean class, so it can be left lower case I think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright.

@@ -266,7 +266,7 @@ have no replacement.

.. _sparse.scipysparse:

Interaction with scipy.sparse
Interaction with *scipy.sparse*
-----------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also adapt the underline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand now; I'm meant to extend the underline to be the same length as the text

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed

@@ -3,7 +3,7 @@
{{ header }}

********************************
Time series / date functionality
Time Series / date functionality
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is not a single word, is there a specific reason to capitalize Series?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. I'll correct that.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @SomtochiUmeh

@jreback jreback merged commit d8bb752 into pandas-dev:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants