New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Add additional test for future warning when call Series.str.cat(Series.str) #47755

Merged

mroeschke merged 5 commits into pandas-dev:main from xr-chen:catstr

Jul 19, 2022

Contributor

xr-chen commented Jul 16, 2022 •

edited by mroeschke

closes series.str.cat(series.str) is concatenating only the largest string #28277 (Replace xxxx with the Github issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

xr-chen added 2 commits

July 16, 2022 15:36


          fix 28277

16280b6


          fix typo

6fa0828

mroeschke requested changes

View reviewed changes

pandas/tests/strings/test_cat.py Outdated Show resolved Hide resolved

mroeschke added the Strings label


          add test

8033d67

xr-chen changed the title ~~BUG: Fix Series.str.cat(Series.str) only concatenate the longest string~~ TST: Add additional test for future warning when call Series.str.cat(Series.str)

mroeschke reviewed

View reviewed changes

pandas/tests/strings/test_cat.py Outdated Show resolved Hide resolved

mroeschke reviewed

View reviewed changes

pandas/tests/strings/test_cat.py Outdated Show resolved Hide resolved


          Update pandas/tests/strings/test_cat.py

775bc5a

Co-authored-by: Matthew Roeschke <emailformattr@gmail.com>

pep8speaks commented Jul 19, 2022 •

edited

Hello @xr-chen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-07-19 00:53:48 UTC


          fix pep 8 issue, change comment symbol

49c0ef9

mroeschke added this to the 1.5 milestone

mroeschke approved these changes

View reviewed changes

mroeschke merged commit 3a39d25 into pandas-dev:main

Member

mroeschke commented Jul 19, 2022

Thanks @xr-chen

xr-chen deleted the catstr branch

July 19, 2022 21:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment