Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: inplace keyword for Categorical.set_ordered, setting .categories directly #47834

Merged
merged 6 commits into from Aug 8, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

xref #37643 (not sure if this closes it since we may want to add a copy=True keyword)

@jbrockmendel jbrockmendel changed the title DEPR: inplcae keyword for Categorical.set_ordered, setting .categories directly DEPR: inplace keyword for Categorical.set_ordered, setting .categories directly Jul 23, 2022
@mroeschke mroeschke added Categorical Categorical Data Type Deprecate Functionality to remove in pandas labels Jul 25, 2022
@mroeschke mroeschke added this to the 1.5 milestone Aug 1, 2022
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. let's merge on green.

@mroeschke mroeschke merged commit 46c615d into pandas-dev:main Aug 8, 2022
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-categorical-inplace branch August 9, 2022 02:02
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
…s directly (pandas-dev#47834)

* DEPR: inplcae keyword for Categorical.set_ordered, setting .categories directly

* update docs

* typo fixup

* suppress warning

Co-authored-by: Jeff Reback <jeff@reback.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants