Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: pandas.core.generic from pandas-stubs #47912

Merged
merged 5 commits into from Aug 1, 2022

Conversation

twoertwein
Copy link
Member

Some annotations from pandas-stubs and some from the underlying io functions.

@pep8speaks
Copy link

pep8speaks commented Aug 1, 2022

Hello @twoertwein! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-08-01 12:59:42 UTC

@twoertwein twoertwein added Deprecate Functionality to remove in pandas Typing type annotations, mypy/pyright type checking labels Aug 1, 2022
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, otherwise lgtm

@mroeschke mroeschke added this to the 1.5 milestone Aug 1, 2022
@mroeschke mroeschke merged commit e12fd56 into pandas-dev:main Aug 1, 2022
@mroeschke
Copy link
Member

Thanks @twoertwein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants