REF: dont alter self in _validate_specification #48051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Aug 12, 2022
mroeschke
approved these changes
Aug 12, 2022
|
good here? follow-up on deck |
|
Thanks @jbrockmendel |
YYYasin19
pushed a commit
to YYYasin19/pandas
that referenced
this pull request
Aug 23, 2022
* REF: dont alter self in _validate_specification * validate_specification->validate_left_right_on
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* REF: dont alter self in _validate_specification * validate_specification->validate_left_right_on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides being better-practice, this will make it easier to annotate. Done separately bc im tracking down what appear to be incorrect annotations that need to be fixed in order to annotate these methods.