Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: sort_columns in plot (#47563) #48073

Merged
merged 1 commit into from Aug 16, 2022
Merged

Conversation

YagoGG
Copy link
Contributor

@YagoGG YagoGG commented Aug 13, 2022

pandas/plotting/_core.py Outdated Show resolved Hide resolved
@YagoGG
Copy link
Contributor Author

YagoGG commented Aug 14, 2022

@phofl thanks for reviewing! I just updated the PR with the requested changes & rebased with the latest main.

Let me know if further changes are needed. Thank you!

@YagoGG YagoGG requested a review from phofl August 14, 2022 10:39
@YagoGG
Copy link
Contributor Author

YagoGG commented Aug 14, 2022

Fixed - thanks!

@YagoGG
Copy link
Contributor Author

YagoGG commented Aug 14, 2022

CI seems to be breaking. Marking as draft while it is fixed.

@YagoGG YagoGG marked this pull request as ready for review August 14, 2022 20:35
@mroeschke mroeschke added Visualization plotting Deprecate Functionality to remove in pandas labels Aug 16, 2022
@mroeschke mroeschke added this to the 1.5 milestone Aug 16, 2022
@mroeschke mroeschke merged commit 8b72297 into pandas-dev:main Aug 16, 2022
@mroeschke
Copy link
Member

Thanks @YagoGG

@phofl
Copy link
Member

phofl commented Aug 16, 2022

linked to deprecation log

@YagoGG YagoGG deleted the depr/47563 branch August 20, 2022 12:55
YYYasin19 pushed a commit to YYYasin19/pandas that referenced this pull request Aug 23, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Visualization plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPR: sort_columns in plot
3 participants