Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: de-duplicate reso-casting code #48953

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added Refactor Internal refactoring of code Non-Nano datetime64/timedelta64 with non-nanosecond resolution labels Oct 5, 2022
@mroeschke
Copy link
Member

mroeschke commented Oct 5, 2022

Could you merge in main once more (GHA was down)?

Also what order of the existing PRs should be reviewed/merged. Getting kinda lost

@jbrockmendel
Copy link
Member Author

Also what order of the existing PRs should be reviewed/merged

This and #48956 should be at the top of the list; not dependent on other PRs while other upcoming PRs depend on them.

The only ones where the order really matters are #48910 then #48918 then #48923. A bunch of upcoming stuff relies on these.

#48819 is preliminary to an upcoming PR doing the same public-ifying for the array methods and accessors.

@jbrockmendel
Copy link
Member Author

greenish

@mroeschke mroeschke added this to the 1.6 milestone Oct 5, 2022
@mroeschke mroeschke merged commit 855ed4e into pandas-dev:main Oct 5, 2022
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-unit branch October 6, 2022 14:09
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non-Nano datetime64/timedelta64 with non-nanosecond resolution Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants