Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: is_categorical #49253

Merged
merged 2 commits into from Oct 24, 2022
Merged

DEPR: is_categorical #49253

merged 2 commits into from Oct 24, 2022
+2 −78

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jbrockmendel jbrockmendel added the Deprecate Functionality to remove in pandas label Oct 23, 2022
@phofl phofl added this to the 2.0 milestone Oct 23, 2022
@phofl
Copy link
Member

phofl commented Oct 23, 2022

needs rebase, otherwise lgtm

@phofl phofl merged commit 3f4854f into pandas-dev:main Oct 24, 2022
@phofl
Copy link
Member

phofl commented Oct 24, 2022

thx @jbrockmendel (could you update the deprecations issue?)

@jbrockmendel jbrockmendel deleted the depr-categorical branch October 24, 2022 14:31
@jbrockmendel jbrockmendel mentioned this pull request Oct 24, 2022
Closed
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@jbrockmendel @noatamir
DEPR: is_categorical (pandas-dev#49253)
3b17ce6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbrockmendel @phofl