Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: enforce deprecation MultiIndex.is_lexsorted and MultiIndex.lexsort_depth #49260

Merged
merged 6 commits into from
Oct 23, 2022

Conversation

lukemanley
Copy link
Member

@lukemanley lukemanley commented Oct 23, 2022

  • Added an entry in the latest doc/source/whatsnew/v2.0.0.rst file if fixing a bug or adding a new feature.

Deprecation introduced in #38701

@lukemanley lukemanley added the Deprecate Functionality to remove in pandas label Oct 23, 2022
@@ -177,6 +177,7 @@ Removal of prior version deprecations/changes
- Remove arguments ``names`` and ``dtype`` from :meth:`Index.copy` and ``levels`` and ``codes`` from :meth:`MultiIndex.copy` (:issue:`35853`, :issue:`36685`)
- Remove argument ``inplace`` from :meth:`MultiIndex.set_levels` and :meth:`MultiIndex.set_codes` (:issue:`35626`)
- Disallow passing positional arguments to :meth:`MultiIndex.set_levels` and :meth:`MultiIndex.set_codes` (:issue:`41485`)
- Removed deprecated :meth:`MultiIndex.is_lexsorted` and :meth:`MultiIndex.lexsort_depth` (:issue:`38701`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove "deprecated"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed it

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc build fails

@lukemanley
Copy link
Member Author

Doc build fails

fixed and now green. thx

@phofl phofl added this to the 2.0 milestone Oct 23, 2022
@phofl phofl merged commit d032652 into pandas-dev:main Oct 23, 2022
@phofl
Copy link
Member

phofl commented Oct 23, 2022

thx @lukemanley (can you update deprecations issue?)

@lukemanley lukemanley deleted the multiindex-lexsort branch October 26, 2022 10:17
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants