CLN: test_nanops.py #49423
Merged
CLN: test_nanops.py #49423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
phofl
reviewed
Nov 3, 2022
pandas/tests/test_nanops.py
Outdated
| ("arr_complex_nan_infj", True), | ||
| ], | ||
| ) | ||
| def test__has_infs_non_float(request, arr, correct, disable_bottleneck): |
pandas/tests/test_nanops.py
Outdated
| ], | ||
| ) | ||
| @pytest.mark.parametrize("astype", [None, "f4", "f2"]) | ||
| def test__has_infs_floats(request, arr, correct, astype, disable_bottleneck): |
pandas/tests/test_nanops.py
Outdated
|
|
||
| @pytest.fixture | ||
| def arr_nan_float1(arr_nan, arr_float1): | ||
| return np.vstack([arr_nan, arr_float1]) |
There was a problem hiding this comment.
Couldn't we just copy arr_nan as the second entry, e.g.
@pytest.fixture
def arr_nan_float1(arr_nan):
return np.vstack([arr_nan, np.copy(arr_float)])
if you don't want to use the same object? Makes it a bit clearer. that the arrays have the same content.
There was a problem hiding this comment.
Good point. Since arr_float1 was was redundant to arr_float, just removed arr_float1
| arr_nan = np.take(arr_nan, 0, axis=-1) | ||
| arr_nan_nan = np.take(arr_nan_nan, 0, axis=-1) | ||
| arr_float_nan = np.take(arr_float_nan, 0, axis=-1) | ||
| arr_float1_nan = np.take(arr_float1_nan, 0, axis=-1) |
There was a problem hiding this comment.
Can we remove one of both lines? IIUC are_float_nan and arr_float1_nan have the same content
There was a problem hiding this comment.
I think these need to be separate objects for the test, but I was able to instantiate 2 separate objects with the same fixture
|
Hopefully addressed all the comments and green |
phofl
approved these changes
Nov 10, 2022
|
thx @mroeschke |
codamuse
pushed a commit
to codamuse/pandas
that referenced
this pull request
Nov 12, 2022
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid
setup_methodbeing unnecessarily called on tests that don't require all the DataFrame/array objects that are being created