DEPR: remove Int64Index, UInt64Index, Float64Index from tests.indexes.numeric #49682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -285,14 +280,12 @@ def test_get_indexer_nearest_decreasing(self, method, expected): | |||
| actual = index.get_indexer([0.2, 1.8, 8.5], method=method) | |||
| tm.assert_numpy_array_equal(actual, np.array(expected, dtype=np.intp)) | |||
|
|
|||
| @pytest.mark.parametrize( | |||
| "idx_class", [Int64Index, RangeIndex, Float64Index, UInt64Index] | |||
There was a problem hiding this comment.
do the RangeIndex cases need to be added back somewhere?
There was a problem hiding this comment.
Good catch. I'll work something into this take this into account.
topper-123
force-pushed
the
remove_old_numeric_indexes_from_tests_part_1
branch
from
cf19354
to
7f697c3
Compare
|
updated. |
mroeschke
approved these changes
Nov 16, 2022
mroeschke
added
the
Testing
|
Thanks @topper-123 |
MarcoGorelli
pushed a commit
to MarcoGorelli/pandas
that referenced
this pull request
Nov 18, 2022
….numeric (pandas-dev#49682) * DEPR: remove Int64Index, UInt64Index, Float64Index from tests.indexes.numeric * add back pylint * RangeIndex in test_indexing.py Co-authored-by: Terji Petersen <terjipetersen@Terjis-Air.fritz.box>
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
….numeric (pandas-dev#49682) * DEPR: remove Int64Index, UInt64Index, Float64Index from tests.indexes.numeric * add back pylint * RangeIndex in test_indexing.py Co-authored-by: Terji Petersen <terjipetersen@Terjis-Air.fritz.box>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #42717. Other locations will follow.
There are tests in here that probably should be parametrized when
Indexwill be able to return non-64 bit dtypes. I'll do that in followups, afterIndexreturns aNumericIndex.