Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Use stronger assertion in test_regression_allowlist_methods #49755

Merged

Conversation

isaac-chung
Copy link
Contributor

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Groupby labels Nov 17, 2022
@mroeschke mroeschke added this to the 2.0 milestone Nov 18, 2022
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Glad this worked. Thoughts on this approach @rhshadrach? (maybe agg should be used instead of apply since these are all reductions?

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

(maybe agg should be used instead of apply since these are all reductions?

apply should produce the same output as agg for a reducer currently, I'm okay with either.

@mroeschke mroeschke merged commit fdb917f into pandas-dev:main Nov 18, 2022
@mroeschke
Copy link
Member

Awesome work @isaac-chung

@isaac-chung
Copy link
Contributor Author

Thanks for your help! @mroeschke

@isaac-chung isaac-chung deleted the 49629-stronger-assertion-allowlist branch November 18, 2022 19:12
mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groupby Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: Use stronger assertion in pandas/tests/groupby/test_allowlist.py::test_regression_allowlist_methods
3 participants