BUG: allow Timestamp comparisons on the left #4983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
whoosh you went all in on this! fused types! |
|
yeah ... there's an annoying vbench hit tho with index joins ... trying to find the source of it ... i actually got rid of the fused types, not necessary since really just |
|
ahh...ok |
|
@jreback comments? |
| @@ -2059,6 +2059,42 @@ def check_comparators(series, other): | |||
| check_comparators(self.ts, 5) | |||
| check_comparators(self.ts, self.ts + 1) | |||
|
|
|||
| def test_timestamp_compare(self): | |||
There was a problem hiding this comment.
not a biggie....but most of the 'time' type ops with series are in tseries/tests/test_timeseries...
|
otherwise looks ok |
|
cool, i'll merge after next travis pass... |
Now tested with Series and DataFrame
For example
Timestamp('now') > pd.NaT
should return the same result as
pd.NaT < Timestamp('now')
but before this commit it didn't because when Timestamp was on the left, the
values were compared whereas if NaT is on the left then the truth values are
hard-coded based on rules like NaN.
cpcloud
added a commit
that referenced
this pull request
Sep 27, 2013
BUG: allow Timestamp comparisons on the left
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4982