BUG: Timestamp.replace handle out-of-pydatetime range #50348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Dec 21, 2022
MarcoGorelli
approved these changes
Jan 4, 2023
MarcoGorelli
requested changes
Jan 4, 2023
There was a problem hiding this comment.
wait sorry, the numpy-dev failure seems legit
2022-12-26T21:13:19.3570839Z _______________________ test_add_out_of_pydatetime_range _______________________
2022-12-26T21:13:19.3571781Z [gw1] linux -- Python 3.10.8 /home/runner/micromamba/envs/test/bin/python
2022-12-26T21:13:19.3572026Z
2022-12-26T21:13:19.3572174Z def test_add_out_of_pydatetime_range():
2022-12-26T21:13:19.3572564Z # don't raise in Timestamp.replace
2022-12-26T21:13:19.3572976Z ts = Timestamp(np.datetime64("-20000-12-31"))
2022-12-26T21:13:19.3573268Z off = YearEnd()
2022-12-26T21:13:19.3573482Z
2022-12-26T21:13:19.3573705Z result = ts + off
2022-12-26T21:13:19.3574104Z expected = Timestamp(np.datetime64("-19999-12-31"))
2022-12-26T21:13:19.3574417Z > assert result == expected
2022-12-26T21:13:19.3574932Z E AssertionError: assert Timestamp('1973-12-31 00:00:00') == Timestamp('-19999-12-31 00:00:00')
MarcoGorelli
added
the
Non-Nano
|
yah i havent been able to reproduce the npdev failure. will add GH refs in the next commit once i figure that out |
|
@seberg any thoughts on reproducing this locally? |
|
Hmmm, unfortunately, can't repro on M1 and I can't think of anything that may have changed in NumPy. |
25 tasks
|
ooh, looks like this fixes #51291, nice! |
MarcoGorelli
approved these changes
Feb 10, 2023
btw I can't reproduce this locally with numpy-dev, the correct answer shows for me |
Co-authored-by: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>
|
let's ship this - thanks @jbrockmendel |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.