DEPR: move NumericIndex._convert_tolerance to Index #50932
Merged
+11
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
move_NumericIndex._convert_tolerance_to_Index
branch
from
6c65328
to
8caa722
Compare
topper-123
force-pushed
the
move_NumericIndex._convert_tolerance_to_Index
branch
from
8caa722
to
37bd4b4
Compare
topper-123
force-pushed
the
move_NumericIndex._convert_tolerance_to_Index
branch
from
37bd4b4
to
d50c82d
Compare
|
Ping. |
pandas/core/indexes/base.py
Outdated
| ) | ||
|
|
||
| raise ValueError( | ||
| f"tolerance argument for {type(self).__name__} must be numeric " |
There was a problem hiding this comment.
should type(self).__name__ here be changed to refer to dtype instead of type?
There was a problem hiding this comment.
Yeah, now that Index can handle a lot of different dtypes (numeric and non-numeric) that makes sense. I'll update.
There was a problem hiding this comment.
Error messages updated.
|
This has also been updated :-) |
|
thanks @topper-123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
_convert_tolerancefromNumericIndextoIndexin preparation to removeNumericIndexand include numpy int/uint/float64 in the baseIndex.xref #42717.