Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Move NumericIndex doc string + some minor stuff #51089

Merged
merged 2 commits into from Jan 31, 2023

Conversation

topper-123
Copy link
Contributor

Moves doc string of NumericIndex to Index. Also moves _can_hold_strings attribute and removes NumericIndex._default_dtype, & NumericIndex._typ.

xref #42717.

@mroeschke mroeschke added Deprecate Functionality to remove in pandas Index Related to the Index class or subclasses labels Jan 31, 2023
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -324,6 +330,9 @@ class Index(IndexOpsMixin, PandasObject):

>>> pd.Index(list('abc'))
Index(['a', 'b', 'c'], dtype='object')

>>> pd.Index([1, 2, 3], dtype="uint8")
NumericIndex([1, 2, 3], dtype='uint8')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be updated later? (when NumericIndex is gone?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I`ll do a ctrl-f to clean up any cruft left at the end.

@phofl phofl added this to the 2.0 milestone Jan 31, 2023
@phofl phofl merged commit 3770dda into pandas-dev:main Jan 31, 2023
@phofl
Copy link
Member

phofl commented Jan 31, 2023

thx @topper-123

@topper-123 topper-123 deleted the move_NumericIndex_docs branch February 1, 2023 00:46
@topper-123 topper-123 mentioned this pull request Feb 3, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Index Related to the Index class or subclasses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants