DEPR: remove NumericIndex.__new__ & ._should_fallback_to_positional #51118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
changed the title
topper-123
changed the title
|
I think the ARM failure is unrelated. |
mroeschke
approved these changes
Feb 2, 2023
mroeschke
added
Deprecate
|
Thanks @topper-123 |
topper-123
deleted the
move_NumericIndex_should_fallback_to_positional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
NumericIndex.__new__&._should_fallback_to_positionalto Index. Next up is to actually removeNumericIndexfrom the code base (there is various scaffolding around, that I need to remove/alter at the same time).This move
NumericIndex._should_fallback_to_positionaltoIndexas-is. There is an issue #51053 that should be fixed, I'll take that in a follow-up so I can getNumericIndexremoved here, without worrying about that.xref #42717.